Change in vdsm[master]: netconf: Improve unified persistence's rollback in memory.
amuller at redhat.com
amuller at redhat.com
Fri Nov 15 20:38:04 UTC 2013
Assaf Muller has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
......................................................................
Patch Set 6:
(1 comment)
....................................................
File vdsm/netconf/__init__.py
Line 65: if self.unifiedPersistence and self.runningConfig is None:
Line 66: self.runningConfig = RunningConfig()
Line 67:
Line 68: def rollback(self):
Line 69: if self.unifiedPersistence:
netconf/__init__.py already imports vdsm.netconfpersistence prior to this patch, I might be missing something obvious, but where is the circular import?
Line 70: restore_net = imp.load_source('restore_net',
Line 71: EXT_VDSM_RESTORE_NET_CONFIG)
Line 72: restore_net.restore_from_memory(self.runningConfig)
Line 73: self.runningConfig = None
--
To view, visit http://gerrit.ovirt.org/20032
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7436976d8bacbfaa1c4b059c71c4abb46192f99a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list