Change in vdsm[master]: Avoid calling restorecon on a nonexistent dir.

danken at redhat.com danken at redhat.com
Fri Nov 15 07:59:33 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Avoid calling restorecon on a nonexistent dir.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File vdsm.spec.in
Line 644: fi
Line 645: 
Line 646: # hack until we replace core dump with abrt
Line 647: /usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
Line 648: /sbin/restorecon -R -v /var/log
This can be slow if the system has many log files, and it may surprise an admin with local tweaks to his file system acl.

How about shipping /var/log/core in the rpm?
Line 649: 
Line 650: %if 0%{?rhel}
Line 651: if [ "$1" -eq 1 ] ; then
Line 652:     /sbin/chkconfig --add vdsmd


-- 
To view, visit http://gerrit.ovirt.org/21290
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd0d14193d9306944649d7ab0ee19edf2ca29ae7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list