Change in vdsm[master]: fcp: Deactivate vdsm logical volumes

nsoffer at redhat.com nsoffer at redhat.com
Thu Nov 14 18:58:19 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: fcp: Deactivate vdsm logical volumes
......................................................................


Patch Set 17:

(2 comments)

....................................................
File lib/vdsm/tool/lvm_deactivate_lvs.py
Line 56: def _log(msg):
Line 57:     sys.stderr.write("%s\n" % (msg,))
Line 58: 
Line 59: 
Line 60: def _iter_vdsm_vgs():
Sorry - I was talking about vgchange bellow.
Line 61:     rc, out, err = _run_lvm(["vgs", "--noheading", "--separator",
Line 62:                              _SEPARATOR, "-o", "name,tags"])
Line 63:     if rc != 0:
Line 64:         raise RuntimeError("Error finding vgs: %s" % err)


Line 70: 
Line 71: 
Line 72: def _iter_active_lvs(vg):
Line 73:     rc, out, err = _run_lvm(["lvs", "--noheading", "--separator",
Line 74:                              _SEPARATOR, "-o", "name,attr", vg])
lvs @tag indeed works.
Line 75:     if rc != 0:
Line 76:         raise RuntimeError("Error finding lvs: %s" % err)
Line 77:     for line in out.splitlines():
Line 78:         line = line.strip()


-- 
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list