Change in vdsm[master]: Enhanced netinfo.getBootProtocol, added unit tests

danken at redhat.com danken at redhat.com
Thu Nov 14 17:37:02 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Enhanced netinfo.getBootProtocol, added unit tests
......................................................................


Patch Set 14: Code-Review-1

(1 comment)

....................................................
File tests/netinfoTests.py
Line 216:         netsDir = os.path.join(tempDir, 'nets')
Line 217:         os.mkdir(netsDir)
Line 218:         networks = {
Line 219:             'nonVMOverNic':
Line 220:             {"nic": "eth0", "bridged": "false", "bootproto": "dhcp"},
Shouldn't the running config be filled with real attributes? I mean, the boolean values True/False, and integral vlan ids?

As it stands, this test serves as a confusing documentation.
Line 221:             'bridgeOverNic':
Line 222:             {"nic": "eth1", "bridged": "true"},
Line 223:             'nonVMOverBond':
Line 224:             {"bonding": "bond0", "bridged": "false", "bootproto": "dhcp"},


-- 
To view, visit http://gerrit.ovirt.org/18484
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list