Change in vdsm[master]: fcp: Deactivate vdsm logical volumes
nsoffer at redhat.com
nsoffer at redhat.com
Thu Nov 14 09:04:48 UTC 2013
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm logical volumes
......................................................................
Patch Set 16:
(1 comment)
....................................................
File init/vdsmd_init_common.sh.in
Line 180: }
Line 181:
Line 182: task_lvm_deactivate_lvs(){
Line 183: "$VDSM_TOOL" lvm-deactivate-lvs
Line 184: }
It is simpler because it is does not have the same functionality, not testable and less modular. Otherwise it is fine :-)
Line 185: #### pre-start tasks end ####
Line 186:
Line 187:
Line 188: #### post-stop tasks ####
--
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list