Change in vdsm[ovirt-3.3]: Invalidate filters on HSMs before rescanning extended VG

fsimonce at redhat.com fsimonce at redhat.com
Wed Nov 13 16:09:04 UTC 2013


Federico Simoncelli has submitted this change and it was merged.

Change subject: Invalidate filters  on HSMs before rescanning extended VG
......................................................................


Invalidate filters  on HSMs before rescanning extended VG

domainMonitor thread might use stale lvm filters while running vgs
command after extending of the VG (added PV is missed in the filter
set). Since LvmCache doesn't invalidate filters, the volume
group  is marked as partial and domainMonitor selftest fails
(host goes to non-operational status). By design filter should be
invalidated if cmd returns nonzero code but vgs returns zero even if
devices are filtered . The patch introduces public  method for
filter invalidation and calls it from the getDevicesVisibility
because getDevicesVisibility is called on all DC hosts after
adding new device but before extendSD.

Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Bugzilla-Url: https://bugzilla.redhat.com/1022976
Signed-off-by: Pavel Zhukov <pzhukov at redhat.com>
Signed-off-by: Sergey Gotliv <sgotliv at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/20552
Reviewed-by: Tomáš Došek <tdosek at redhat.com>
Reviewed-by: Sergey Gotliv <sgotliv at redhat.com>
Reviewed-by: Ayal Baron <abaron at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21223
Reviewed-by: Allon Mureinik <amureini at redhat.com>
---
M vdsm/storage/hsm.py
M vdsm/storage/lvm.py
2 files changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Federico Simoncelli: Looks good to me, approved
  Sergey Gotliv: Verified
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/21223
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdosek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list