Change in vdsm[master]: fcp: Deactivate vdsm logical volumes

amureini at redhat.com amureini at redhat.com
Wed Nov 13 15:24:06 UTC 2013


Allon Mureinik has posted comments on this change.

Change subject: fcp: Deactivate vdsm logical volumes
......................................................................


Patch Set 12:

(1 comment)

....................................................
File lib/vdsm/tool/lvm_deactivate_lvs.py
Line 36:     """
Line 37:     if _was_run():
Line 38:         _log("already run")
Line 39:         return 0
Line 40:     _set_was_run()
Sounds good to me.
(note that we will succeed even if not all the lvs are deactivated).

I don't see a downside here. What am I missing?
Line 41:     for vg in _iter_vdsm_vgs():
Line 42:         _deactivate_lvs(vg)
Line 43:     _log("deactivated lvs")
Line 44:     return 0


-- 
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list