Change in vdsm[master]: tests: Add simple mocking library

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 13 12:40:29 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: tests: Add simple mocking library
......................................................................


Patch Set 1:

(1 comment)

....................................................
Commit Message
Line 5: CommitDate: 2013-11-12 11:11:04 +0200
Line 6: 
Line 7: tests: Add simple mocking library
Line 8: 
Line 9: New mock module provides a MockCallable, useful for mocking functions
This is not monkeypatching, this is mocking - totally different concept. We cannot improve monkeypatch without adding mocks :-)

You typically use monkeypatching to install mocks, but you can also install fakes or other stuff. Some mocking libraries include monkeypatching, so we can merge  both modules under the new mock module. However, this is out of the scope of this change.
Line 10: and other callables required for testing stuff that needs special
Line 11: environment for running.
Line 12: 
Line 13: MockCallable is using the record and play aprroach; After a mock is


-- 
To view, visit http://gerrit.ovirt.org/21155
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5d874f553b6a983652ed745d7d8554716e7a15e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list