Change in vdsm[master]: clientIF: Check device visibility on failed hotplugDisk

sgotliv at redhat.com sgotliv at redhat.com
Wed Nov 13 09:32:31 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: clientIF: Check device visibility on failed hotplugDisk
......................................................................


Patch Set 2:

(1 comment)

....................................................
Commit Message
Line 9: According to the analysis in the bug, invoking vmHotplugDisk right after
Line 10: connectStorageServer may not leave enough time for multipath to create
Line 11: the device, leading to incorrect failure.
Line 12: 
Line 13: The original fix failed to invoke multipath.rescan(), and the bug was
How would you know that rescan is done? It's not triggered by VDSM and happens behind the scene. 
You probably can monitor guid as suggested by Dan which is applicable wnen you want to check one guid only. Much safer is calling explicitly to rescan as suggested by that patch.
Line 14: verified by QE and used by customers for the last 6 month. We believe
Line 15: that the problem is a tiny race that is unlikely to happen, but it is
Line 16: possible and should be fixed.
Line 17: 


-- 
To view, visit http://gerrit.ovirt.org/21181
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list