Change in vdsm[master]: tests: Add NetworkTest.testAddDelNetworkDhcp

danken at redhat.com danken at redhat.com
Wed Nov 13 09:18:56 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: tests: Add NetworkTest.testAddDelNetworkDhcp
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

....................................................
File tests/functional/dnsmasq.py
Line 40:                             dhcpRangeTo, '--dhcp-option=3', '-k', '-i',
Line 41:                             interface], sync=False)
Line 42:         '''
Line 43:         TODO this doesn't seem to be working - when dnsmasq fails to start,
Line 44:         the returncode of vdsm.utils.AsyncProc is still None when dnsmasq
there's an inherent race here, due to sync=False. You should raise SkipTest only after vdsm reports that it has failed to acquire an address (but before you attempt to kill dnsmasq). This would give the dnsmasq process enough time to attempt to start up.
Line 45:         is a zombie
Line 46:         '''
Line 47:         if self.proc.returncode:
Line 48:             raise SkipTest('Failed to start dnsmasq DHCP server.')


....................................................
File tests/functional/networkTests.py
Line 1541:         with vethIf() as (left, right):
Line 1542:             veth.setIP(left, IP_ADDRESS, IP_CIDR)
Line 1543:             veth.setLinkUp(left)
Line 1544:             with dnsmasqDhcp(left):
Line 1545:                 status, msg = self.vdsm_net.addNetwork(NETWORK_NAME,
sorry for noticing this only now, but please test with the modern setupNetworks() verb, not with add/del, which we'd like to deprecate at some point.
Line 1546:                                                        nics=[right],
Line 1547:                                                        opts={'bridged':
Line 1548:                                                              bridged,
Line 1549:                                                              'bootproto':


-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas <pbenas at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Benas <pbenas at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list