Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism

danken at redhat.com danken at redhat.com
Tue Nov 12 21:29:14 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
......................................................................


Patch Set 13:

(3 comments)

Assaf, Yaniv Bronhaim wrote on Oct 24 15:44 (UTC+1)
"""
Patch Set 10: Code-Review-1

I like the vdsm-tool logger idea, but do it separately to your feature please.
"""

I suppose you could comply with this request; it makes more sense to set up logging when vdsm-tool starts rather in a particular module thereof.

....................................................
Commit Message
Line 9: Unified network persistence feature:
Line 10: http://www.ovirt.org/Feature/NetworkReloaded#Unified_persistence
Line 11: 
Line 12: This patch is the first of two patches that implement an upgrade
Line 13: that is the ran the first time VDSM that uses unified network
... and fix the past participle form of "run".
Line 14: persistence is started. The goal is to look at the current
Line 15: host networking configuration and populate the running config.
Line 16: 
Line 17: Please see the next patch in the series:


....................................................
File lib/vdsm/tool/upgrade.py
Line 45:     def seal(self):
Line 46:         """
Line 47:             Mark the upgrade as a success
Line 48:         """
Line 49:         self.log.debug("Upgrade %s successfully performed" % self.upgradeName)
log only AFTER the seal() has succeeded.


Line 46:         """
Line 47:             Mark the upgrade as a success
Line 48:         """
Line 49:         self.log.debug("Upgrade %s successfully performed" % self.upgradeName)
Line 50:         open(self.upgradeFilePath, 'w').close()
If I recall ancient discussions, haven't we find a reason to write vdsm's version into that file? (don't add it unless the reason was really good, and explain it.)


-- 
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list