Change in vdsm[master]: jsonrpc: Create the java bindings and fix bugs
mtayer at redhat.com
mtayer at redhat.com
Tue Nov 12 16:21:49 UTC 2013
mooli tayer has posted comments on this change.
Change subject: jsonrpc: Create the java bindings and fix bugs
......................................................................
Patch Set 6:
(2 comments)
....................................................
File client/java/vdsm-api/src/main/java/org/ovirt/vdsm/RequestBuilder.java
Line 8:
Line 9: private String _id;
Line 10: private static final ObjectMapper _objMapper;
Line 11: private final ObjectNode _parameters;
Line 12: private final String _methodName;
It makes me sad when you don't follow java's naming conventions.
Line 13:
Line 14: static {
Line 15: _objMapper = new ObjectMapper();
Line 16: }
....................................................
File client/java/vdsm-api/src/main/java/org/ovirt/vdsm/VDSMClientPool.java
Line 18: _reactors = reactors;
Line 19: _cpool = new JsonRpcClientPool();
Line 20: }
Line 21:
Line 22: public VDSMClient createClient(URI uri) {
What is VDSMClient? Where does it come from?
I can't seem to compile without it.
Line 23: final Reactor reactor = _reactors.get(uri.getScheme().toLowerCase());
Line 24: if (reactor == null) {
Line 25: throw new IllegalArgumentException("URI scheme is invalid");
Line 26: }
--
To view, visit http://gerrit.ovirt.org/19497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list