Change in vdsm[master]: vm: pre-validate disks for snapshot

laravot at redhat.com laravot at redhat.com
Tue Nov 12 14:39:28 UTC 2013


Liron Ar has posted comments on this change.

Change subject: vm: pre-validate disks for snapshot
......................................................................


Patch Set 4:

(2 comments)

....................................................
File vdsm/vm.py
Line 3704:                 return errCode['snapshotErr']
Line 3705: 
Line 3706:             if vmDrive.hasVolumeLeases:
Line 3707:                 self.log.error("Disk %s has volume leases", vmDrive.name)
Line 3708:                 return errCode['noimpl']
consider changing also the error code
Line 3709: 
Line 3710:             if vmDrive.transientDisk:
Line 3711:                 self.log.error("Disk %s is a transient disk", vmDrive.name)
Line 3712:                 return errCode['transientErr']


Line 3730:             except Exception:
Line 3731:                 self.log.error("Unable to prepare the volume path "
Line 3732:                                "for the disk: %s", vmDevName, exc_info=True)
Line 3733:                 # Trying to rollback (teardown) all drives
Line 3734:                 _rollbackDrives(newDrives)
should be done only for the drives that we already did the operation for instead of all of the drives.
Line 3735:                 return errCode['snapshotErr']
Line 3736: 
Line 3737:             snapelem = _diskSnapshot(vmDevName, newDrives[vmDevName]["path"])
Line 3738:             disks.appendChild(snapelem)


-- 
To view, visit http://gerrit.ovirt.org/20029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fb507c2f7268bb688af5fd187dcd033d0a068a2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list