Change in vdsm[master]: Enhanced netinfo.getBootProtocol

amuller at redhat.com amuller at redhat.com
Tue Nov 12 13:44:00 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Enhanced netinfo.getBootProtocol
......................................................................


Patch Set 12:

(3 comments)

....................................................
File lib/vdsm/netinfo.py
Line 471: 
Line 472:         # If the network is bridged its iface name will be its network name
Line 473:         network = runningConfig.networks.get(iface)
Line 474:         if network is not None:
Line 475:             return network.get('bootproto', 'none')
There is a reason I changed it from None to 'none', even though it's different than how it works with ifcfg persistence. I'll check into it...
Line 476: 
Line 477:         # Otherwise we need to search if the iface is the device for a network
Line 478:         for network, attributes in runningConfig.networks.iteritems():
Line 479:             if iface in (attributes.get('nic'), attributes.get('bonding')):


Line 475:             return network.get('bootproto', 'none')
Line 476: 
Line 477:         # Otherwise we need to search if the iface is the device for a network
Line 478:         for network, attributes in runningConfig.networks.iteritems():
Line 479:             if iface in (attributes.get('nic'), attributes.get('bonding')):
Good one... Kind of annoyed I didn't catch it myself.
Line 480:                 return attributes.get('bootproto', 'none')
Line 481:     else:
Line 482:         raise NotImplementedError
Line 483: 


Line 476: 
Line 477:         # Otherwise we need to search if the iface is the device for a network
Line 478:         for network, attributes in runningConfig.networks.iteritems():
Line 479:             if iface in (attributes.get('nic'), attributes.get('bonding')):
Line 480:                 return attributes.get('bootproto', 'none')
Absolutely.
Line 481:     else:
Line 482:         raise NotImplementedError
Line 483: 
Line 484: 


-- 
To view, visit http://gerrit.ovirt.org/18484
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list