Change in vdsm[master]: remove irs_enable configuration attribute

ahadas at redhat.com ahadas at redhat.com
Tue Nov 12 08:31:44 UTC 2013


Arik Hadas has posted comments on this change.

Change subject: remove irs_enable configuration attribute
......................................................................


Patch Set 2:

(3 comments)

....................................................
Commit Message
Line 5: CommitDate: 2013-11-11 10:11:05 -0500
Line 6: 
Line 7: remove irs_enable configuration attribute
Line 8: 
Line 9: The configuration of vdsm included an attribute called 'irs_enable'
I changed the commit message, sticking more to the facts of how it is today.

I came across this attribute accidentally, and I realized that setting it to false might conflict with a change I already made in the engine: http://gerrit.ovirt.org/#/c/17815/ (the engine tries to fetch the iso prefix from the host the VM is about to run on if it's not already defined, but if that host is set with irs_enable=false then we'll have a problem)

So maybe there's such a use-case where it can be useful to set irs_enable=false but currently it will be problematic for the flow described above and when the engine tries to set such host as SPM. so as long as it is not supported well in the system I think we should drop it and maybe add it in a proper way once we'll find that it might be useful.
Line 10: which was supposed to make it possible to set a specific host as non
Line 11: eligible to serve as SPM.
Line 12: 
Line 13: This configuration is not supported (the engine will just try to


....................................................
File vdsm/clientIF.py
Line 247:         while self._enabled:
Line 248:             time.sleep(3)
Line 249: 
Line 250:     def _initIRS(self):
Line 251:         self.irs = None
right, Done
Line 252:         try:
Line 253:             self.irs = Dispatcher(HSM())
Line 254:         except:
Line 255:             self.log.error("Error initializing IRS", exc_info=True)


Line 250:     def _initIRS(self):
Line 251:         self.irs = None
Line 252:         try:
Line 253:             self.irs = Dispatcher(HSM())
Line 254:         except:
I'll need to detect all the possible exceptions which can be thrown when calling HSM constructor and Dispatcher method. it is not too complex but it is not trivial either and I think it is not really related to this change, so let's not couple it with this patch.
Line 255:             self.log.error("Error initializing IRS", exc_info=True)
Line 256:         else:
Line 257:             self.irs.registerDomainStateChangeCallback(self.contEIOVms)
Line 258: 


-- 
To view, visit http://gerrit.ovirt.org/21141
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7520f0691d10c7d79377724c1aadcae0173e5bae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list