Change in vdsm[master]: vm: unify _highWrite and _onAbnormalStop
sgotliv at redhat.com
sgotliv at redhat.com
Tue Nov 12 05:12:16 UTC 2013
Sergey Gotliv has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
......................................................................
Patch Set 5:
(2 comments)
I would consider to change the name of the method, except of that looks great.
....................................................
File vdsm/vm.py
Line 2279: self.log.debug('new rtc offset %s', timeOffset)
Line 2280: with self._confLock:
Line 2281: self.conf['timeOffset'] = timeOffset
Line 2282:
Line 2283: def checkDrivesForExtension(self):
Agree.
Line 2284: extend = []
Line 2285:
Line 2286: for drive in self._devices[DISK_DEVICES]:
Line 2287: if not drive.blockDev or drive.format != 'cow':
Line 2298: drive.volumeID, drive.domainID, drive.apparentsize, capacity,
Line 2299: alloc, physical)
Line 2300: self.extendDriveVolume(drive)
Line 2301:
Line 2302: return len(extend) > 0
I don't agree here, more than that this patch won't be merged without another, we all know that, so...
Line 2303:
Line 2304: def extendDriveVolume(self, vmDrive):
Line 2305: if not vmDrive.blockDev:
Line 2306: return
--
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list