Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG

abaron at redhat.com abaron at redhat.com
Mon Nov 11 08:45:11 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Invalidate filters  on HSMs before rescanning extended VG
......................................................................


Patch Set 18:

Dan, clearly there is not enough clarity on the flow which is leading you to wrongly think there is a race here.
The flow is:
on SPM host:
 discover and connect to storage (optional)
 getDeviceList
in GUI choose a new device to add to domain

Now *before* vgextend is run, on *all* hosts:
 discover and connect to storage (if needed)
 getDevicesVisibility

Only after all hosts have reported that the new device(s) is visible (and filter is up to date) do we go back to the spm and run:
 vgextend

On top of all this, a host only moves to non-op after *5* minutes !!! (to differentiate between host and total storage failure).

So now is it clear that there is no race?

-- 
To view, visit http://gerrit.ovirt.org/20552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdosek at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list