Change in vdsm[master]: iproute2 ip link wrapper

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 11 01:05:12 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: iproute2 ip link wrapper
......................................................................


Patch Set 8:

(1 comment)

....................................................
File lib/vdsm/ipwrapper.py
Line 88:                                   self.address)
Line 89: 
Line 90:     @staticmethod
Line 91:     def parse(text):
Line 92:         """parses a line of output from "ip -o -d link" into a Link attribute
That pep is wrong; this is a good docstring :-)
Line 93:         dictionary and returns it."""
Line 94:         attrs = {}
Line 95:         attrs['index'], attrs['name'], data = [el.strip() for el in
Line 96:                                                text.split(':', 2)]


-- 
To view, visit http://gerrit.ovirt.org/21054
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeee70574536e838076704e76f86f2777d5db9b0
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list