Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...

nsoffer at redhat.com nsoffer at redhat.com
Fri Nov 8 21:21:02 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: hsm: Rescan multipath if device is missing when scanning devices
......................................................................


Patch Set 4:

Changes:

- Fix dirty monkey patching in hsmTests.FakeMultipath.
- Monkey patch at test level instead of class level when monkey patched object contains state, preventing case when one test can effect another test results.
- Improve test rig, cleaning up the tests.

This patch is ready for merge if we want to keep the fix for 923773 introduced by 15c7f74365cb5.

-- 
To view, visit http://gerrit.ovirt.org/20942
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list