Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG

pzhukov at redhat.com pzhukov at redhat.com
Fri Nov 8 19:01:50 UTC 2013


Pavel Zhukov has posted comments on this change.

Change subject: Invalidate filters  on HSMs before rescanning extended VG
......................................................................


Patch Set 18:

Dan, I though about it (that's why I've submitted wrong patch first time actually). But vgck is not able to manipulate (update) LVMCache (well it can only if rc != 0, but it invalidates filter before second attempt anyway). The vgck logic works properly because It invalidates filters if vg is partial (retcode = 5).  

You can check the logs attached to the bugzilla. There is ~200 secs between getDevVisibil. and vgs calls so vgs used updated filters but (actually) outdated LVMCache this time.

-- 
To view, visit http://gerrit.ovirt.org/20552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdosek at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list