Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...

sgotliv at redhat.com sgotliv at redhat.com
Fri Nov 8 18:08:25 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: hsm: Rescan multipath if device is missing when scanning devices
......................................................................


Patch Set 3: -Code-Review

This is not a code review anymore. Nir I will explain the joke regarding similarity of this one to the "famous" patch in the office.

Nir, Dan

I agree with you both:

1. Code is nice and working.

2. Scan... API should be removed (or become non public)

Please, consider instead of completely revert the original patch (not yours Nir) just call getDeviceVisibility() instead of ScanDeviceVisibility() from clientIF the only place which is using Scan. API.. directly. Then Scan... can become a private method of hsm.

-- 
To view, visit http://gerrit.ovirt.org/20942
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list