Change in vdsm[master]: iproute2 ip link wrapper

asegurap at redhat.com asegurap at redhat.com
Fri Nov 8 17:23:15 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: iproute2 ip link wrapper
......................................................................


Patch Set 5:

(3 comments)

....................................................
File lib/vdsm/ipwrapper.py
Line 53: 
Line 54: @equals
Line 55: class Link(object):
Line 56:     """Represents link information obtained from iproute2"""
Line 57:     #kinds
Done
Line 58:     NIC = 'nic'
Line 59:     VLAN = 'vlan'
Line 60:     BOND = 'bond'
Line 61:     BRIDGE = 'bridge'


....................................................
File lib/vdsm/netinfo.py
Line 69: def _match_name(name, patterns):
Line 70:     return any(map(lambda p: fnmatch(name, p), patterns))
Line 71: 
Line 72: 
Line 73: def _nicDevices():
ok
Line 74:     """
Line 75:     Returns a list of nic devices real or fakes,
Line 76:     available on the host.
Line 77:     """


Line 81:     devices = []
Line 82:     for device in deviceLinks:
Line 83:         if device.kind == Link.NIC or (device.kind == Link.DUMMY and
Line 84:            _match_name(device.name, fakeNics)):
Line 85:             devices.append(device.name)
Done
Line 86:     return devices
Line 87: 
Line 88: 
Line 89: def nics():


-- 
To view, visit http://gerrit.ovirt.org/21054
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeee70574536e838076704e76f86f2777d5db9b0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list