Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...

danken at redhat.com danken at redhat.com
Fri Nov 8 15:52:41 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: hsm: Rescan multipath if device is missing when scanning devices
......................................................................


Patch Set 3:

(1 comment)

....................................................
File vdsm/storage/hsm.py
Line 1981: 
Line 1982:         return devices
Line 1983: 
Line 1984:     @public
Line 1985:     def scanDevicesVisibility(self, guids):
Obviously, getDevicesVisibility has to be fixed. The only question is how. I believe that reverting the offending commit is our best approach, since it added complexity, added an undocumented API, solved nothing, and incurred a regression.

getDeviceList() is called on one host (most probably the SPM), and getDevicesVisibility() - on all other hosts (or on the host attempting to start a vm with a direct LUN). getDevicesVisibility has acquired an undocumented meaning of hinting the host that a new device may be around.
Line 1986:         def visible(guid):
Line 1987:             path = os.path.join("/dev/mapper", guid)
Line 1988:             return os.path.exists(path)
Line 1989:         visibility = map(visible, guids)


-- 
To view, visit http://gerrit.ovirt.org/20942
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list