Change in vdsm[master]: Transmogrify netinfo gateway default value from 0.0.0.0 to ''

danken at redhat.com danken at redhat.com
Thu Nov 7 15:01:34 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Transmogrify netinfo gateway default value from 0.0.0.0 to ''
......................................................................


Transmogrify netinfo gateway default value from 0.0.0.0 to ''

Antecedently, if a device lacked IP addressing information,
netinfo proclaimed the ipaddr as '', netmask as ''
and gateway as '0.0.0.0'.

The transpose from '0.0.0.0' to '' is momentous both for congruity
and for input corroboration during setupNetworks. setupNetwrosk would
fail for an (ip: '', netmask: '', gateway: '0.0.0.0'). This
can bechance if the unified network persistence upgrade was
perpetrated on a network with no ip configuration.

The next time I get a -1 on a commit message I promise to
reword it to Biblical English (Present work excluded).

Change-Id: I64ec08bb57f317b30038c3b53851d6a9a4a90e86
Signed-off-by: Assaf Muller <amuller at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/20912
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netinfo.py
1 file changed, 11 insertions(+), 7 deletions(-)

Approvals:
  Assaf Muller: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20912
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I64ec08bb57f317b30038c3b53851d6a9a4a90e86
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>


More information about the vdsm-patches mailing list