Change in vdsm[master]: Transmogrify netinfo gateway default value from 0.0.0.0 to ''

amuller at redhat.com amuller at redhat.com
Thu Nov 7 10:39:58 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Transmogrify netinfo gateway default value from 0.0.0.0 to ''
......................................................................


Patch Set 2:

(2 comments)

....................................................
Commit Message
Line 5: CommitDate: 2013-11-06 10:45:41 +0200
Line 6: 
Line 7: Change netinfo gateway default value from 0.0.0.0 to ''
Line 8: 
Line 9: Previously, if a device does not have an ip addr, netmask and
Done
Line 10: gateway then netinfo will report the ipaddr as '', netmask as ''
Line 11: and gateway as '0.0.0.0'.
Line 12: 
Line 13: The change (From '0.0.0.0' to '') is important both for consistency


....................................................
File lib/vdsm/netinfo.py
Line 339:         return ''
Line 340:     return prefix2netmask(netmask)
Line 341: 
Line 342: 
Line 343: def getgateway(dev):
Done
Line 344:     return getRoutes().get(dev, '')
Line 345: 
Line 346: 
Line 347: def getIpInfo(dev):


-- 
To view, visit http://gerrit.ovirt.org/20912
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64ec08bb57f317b30038c3b53851d6a9a4a90e86
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list