Change in vdsm[master]: gluster: correct parameter for creating hookpath in verb hoo...

dnarayan at redhat.com dnarayan at redhat.com
Thu Nov 7 10:17:21 UTC 2013


Hello Bala.FA,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/21017

to review the following change.

Change subject: gluster: correct parameter for creating hookpath in verb hookAdd.
......................................................................

gluster: correct parameter for creating hookpath in verb hookAdd.

parameter hookLevel must be in lower case for creating correct
path for hook. so that parameter is changed to lower case.

bug url: https://bugzilla.redhat.com/show_bug.cgi?id=1024263
Change-Id: Ia7806316f7cdfaa7d6f42323e6db45886a97f9d6
Signed-off-by: ndarshan <dnarayan at redhat.com>
---
M vdsm/gluster/hooks.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/21017/1

diff --git a/vdsm/gluster/hooks.py b/vdsm/gluster/hooks.py
index e1f0a79..75c8470 100644
--- a/vdsm/gluster/hooks.py
+++ b/vdsm/gluster/hooks.py
@@ -248,7 +248,7 @@
 @makePublic
 def hookAdd(glusterCmd, hookLevel, hookName, hookData, hookMd5Sum,
             enable=False):
-    hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel)
+    hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel.lower())
     try:
         os.makedirs(hookPath)
         if selinux.is_selinux_enabled():


-- 
To view, visit http://gerrit.ovirt.org/21017
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7806316f7cdfaa7d6f42323e6db45886a97f9d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>


More information about the vdsm-patches mailing list