Change in vdsm[master]: vm: fix _devices access in _highWrite

sgotliv at redhat.com sgotliv at redhat.com
Wed Nov 6 18:37:14 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: vm: fix _devices access in _highWrite
......................................................................


Patch Set 3:

(1 comment)

....................................................
File vdsm/vm.py
Line 2297:                 self.log.error(
Line 2298:                     "Allocated size %s cannot be higher than the disk "
Line 2299:                     "capacity %s for volume %s on domain %s", alloc,
Line 2300:                     capacity, drive.domainID, drive.volumeID)
Line 2301:                 self.pause(pauseCode='EOTHER')
It looks like you change original logic:

One of previous comments was that there is no need to extend drives if one of them has alloc > capacity.
Line 2302: 
Line 2303:         for drive, capacity, alloc, physical in extend:
Line 2304:             self.log.info('%s/%s apparent: %s capacity: %s, alloc: %s, '
Line 2305:                           'physical: %s', drive.domainID, drive.volumeID,


-- 
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list