Change in vdsm[master]: vm: fix _devices access in _highWrite

fsimonce at redhat.com fsimonce at redhat.com
Wed Nov 6 17:58:35 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: vm: fix _devices access in _highWrite
......................................................................


Patch Set 3:

(2 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-11-06 08:50:57 -0500
Line 4: Commit:     Federico Simoncelli <fsimonce at redhat.com>
Line 5: CommitDate: 2013-11-06 12:46:50 -0500
Line 6: 
Line 7: vm: fix _devices access in _highWrite
We probably need a new commit message.
Line 8: 
Line 9: Main focus of this patch was to fix two attribute errors:
Line 10: 
Line 11: - self._devices (in VmStatsThread._extendVmDrives)


Line 14: It soon appeared clear that it would have been more logical to
Line 15: move _extendVmDrives to the VM object in order to solve them all
Line 16: at once.
Line 17: 
Line 18: In this patch:
Maybe we need to split all this. As far as I'm concerned I'd prefer to keep them all together.
Line 19: - rename _extendVmDrives to checkDrivesForExtension and move it
Line 20:   to the Vm object
Line 21: - remove (the now unused) InvalidAllocError
Line 22: - move the "No VM drives were extended" logging message to the


-- 
To view, visit http://gerrit.ovirt.org/20966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fd790986b81402847b06810529841cfd7bae119
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list