Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports

danken at redhat.com danken at redhat.com
Wed Nov 6 12:19:25 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: pre-defined range for spice/vnc ports
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 35: # update the libvirt configure file every time we change vdsm package
Line 36: # version. In fact the configure generated here is almost unrelated to the
Line 37: # package version, so anything meaningful can be used here. Since a hard
Line 38: # coded version string has been already used, for compatibility we will
Line 39: # continue to use this string.
please fix
Line 40: BY_VDSM_VERS="4.10.3"
Line 41: 
Line 42: [ "${ENABLE_LIBVIRT_SANLOCK}" = "yes" ] || QLCONF="/dev/null"
Line 43: 


-- 
To view, visit http://gerrit.ovirt.org/17058
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list