Change in vdsm[master]: Introducing configurator package in vdsm-tool

danken at redhat.com danken at redhat.com
Wed Nov 6 10:41:01 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Introducing configurator package in vdsm-tool
......................................................................


Patch Set 27:

(1 comment)

....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 103:         # so continue to use system default init mechanism
Line 104:         return 0
Line 105:     fi
Line 106: 
Line 107:     "@CHKCONFIG_PATH@" libvirtd off
If indeed this code now runs only when you must configure (check), then you can keep the change.
Line 108: 
Line 109:     if ! diff -q "${packaged}" "${target}" >/dev/null 2>&1; then
Line 110:         /bin/cp -p "${packaged}" "${target}" || return 1
Line 111:         /sbin/initctl reload-configuration


-- 
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list