Change in vdsm[master]: hsm: Rescan multipath if device is missing when scanning dev...

amureini at redhat.com amureini at redhat.com
Wed Nov 6 10:30:16 UTC 2013


Allon Mureinik has posted comments on this change.

Change subject: hsm: Rescan multipath if device is missing when scanning devices
......................................................................


Patch Set 2:

(2 comments)

....................................................
Commit Message
Line 9: Commit 15c7f74365cb5 introduced a regression where multipath rescan is
Line 10: never performed if a device is missing when scanning devices. This can
Line 11: cause a host to become non-operational when extending a vg.
Line 12: 
Line 13: The orignal code used a lambda to create an named function, to be used
s/an/a/
Line 14: in map call later. lambdas have their use, but they are poor choice for
Line 15: a named function. Due to lambda syntax limitations and pep8 indentation
Line 16: police, it was hard to notice that the lambda returned a tuple and not a
Line 17: boolean, creating list of non-empty tuples.  Applying all() to such list


Line 10: never performed if a device is missing when scanning devices. This can
Line 11: cause a host to become non-operational when extending a vg.
Line 12: 
Line 13: The orignal code used a lambda to create an named function, to be used
Line 14: in map call later. lambdas have their use, but they are poor choice for
I'd lose this sentance (labdas have their use, etc.)
Line 15: a named function. Due to lambda syntax limitations and pep8 indentation
Line 16: police, it was hard to notice that the lambda returned a tuple and not a
Line 17: boolean, creating list of non-empty tuples.  Applying all() to such list
Line 18: returns always True. Finally this code path was not verified, probably


-- 
To view, visit http://gerrit.ovirt.org/20942
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d5be2f73b644c194625e08654784e0aad64aee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list