Change in vdsm[ovirt-3.3]: lvm: Do not use udev cache for obtaining device list

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 5 16:51:17 UTC 2013


Hello Ayal Baron, Allon Mureinik, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/20939

to review the following change.

Change subject: lvm: Do not use udev cache for obtaining device list
......................................................................

lvm: Do not use udev cache for obtaining device list

lvm is obtaining the device list from udev. When using concurrently,
udev sometimes returns incomplete list, which cause lvm to think that a
vg is missing, and the command may fail with "Volume group not found"
error, or "Cannot change VG test while PVs are missing".

lvm fixed this issue in version 2.02.100-7.el6 by disabling udev cache,
setting obtain_device_list_from_udev to 0. Unfortunatlly, lvm fix is not
enough for vdsm, as the fix is applied only if no lvm.conf file exists.
When upgrading existing lvm installation, lvm creates a lvm.conf.rpmnew
file, and the system administrator is responsible for updating lvm
configuration.

This patch disable udev cache using the --config option, used to
override many other lvm options, ensuring proper configuration on both
new and upgraded systems.

Disabling udev cache may have minimal performance effect according to
lvm developers.

Change-Id: Ib55c8d444f3be9f63bfd23d8def60607b5b3dff0
Bug-Url: https://bugzilla.redhat.com/1014942
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/20890
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Ayal Baron <abaron at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
---
M vdsm/storage/lvm.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/20939/1

diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 0c2964e..065e1ea 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -105,6 +105,7 @@
 ignore_suspended_devices=1
 write_cache_state=0
 disable_after_error_count=3
+obtain_device_list_from_udev=0
 %s
 }
 


-- 
To view, visit http://gerrit.ovirt.org/20939
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib55c8d444f3be9f63bfd23d8def60607b5b3dff0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list