Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...
danken at redhat.com
danken at redhat.com
Tue Nov 5 14:13:56 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts installed
......................................................................
Patch Set 9:
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 124: If the directory doesn't exist is assumed that it was already removed.
Line 125: """
Line 126: try:
Line 127: shutil.rmtree(directoryToRemove)
Line 128: except OSError as e:
Thanks, but I find it important not to silently swallow exceptions. I'll add logging to the positive flow myself.
Line 129: if e.errno != errno.ENOENT:
Line 130: raise
Line 131:
Line 132: IPXMLRPCRequestHandler = SimpleXMLRPCRequestHandler
--
To view, visit http://gerrit.ovirt.org/20310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel at ajo.es>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel at ajo.es>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list