Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG

danken at redhat.com danken at redhat.com
Tue Nov 5 08:50:54 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Invalidate filters  on HSMs before rescanning extended VG
......................................................................


Patch Set 17:

(1 comment)

....................................................
Commit Message
Line 15: devices are filtered . The only way to invalidate filter now is flush LvmCache.
Line 16: To avoid perfomance issues the patch introduces public method for filter invalidation
Line 17: and calls it from the getDevicesVisibility. As far as getDevicesVisibility
Line 18: is called to all added devices this allows to reload filters  every time
Line 19: after new devices has been mapped but before vgscan.
So please state in the commit message that getDevVis is called on all DC hosts before extendSD. That would have answered my question. It's worth documenting in getDevVis, too.
Line 20: 
Line 21: Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Line 22: Bugzilla-Url: https://bugzilla.redhat.com/1022976


-- 
To view, visit http://gerrit.ovirt.org/20552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdosek at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list