Change in vdsm[master]: lvm: Prevent auto-activation of vdsm logical volumes

ewarszaw at redhat.com ewarszaw at redhat.com
Tue Nov 5 07:40:38 UTC 2013


Eduardo has posted comments on this change.

Change subject: lvm: Prevent auto-activation of vdsm logical volumes
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

....................................................
File vdsm/storage/lvm.py
Line 787: 
Line 788: def _setLVAvailability(vg, lvs, available):
Line 789:     attrs = LV_ACTIVATE_FLAGS if available == "y" else LV_DEACTIVATE_FLAGS
Line 790:     try:
Line 791:         changelv(vg, lvs, attrs)
Adding here instead in changelv() the skip flags requires from each caller doing activation to send the proper flag and being aware of the defined constants.
Line 792:     except se.StorageException as e:
Line 793:         error = ({"y": se.CannotActivateLogicalVolumes,
Line 794:                   "n": se.CannotDeactivateLogicalVolume}
Line 795:                  .get(available, se.VolumeGroupActionError))


-- 
To view, visit http://gerrit.ovirt.org/20832
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie001c5a4c888bb1ca44bedaeeae6fb75e7cbacc0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list