Change in vdsm[master]: Monitor bridges using vdsStats

danken at redhat.com danken at redhat.com
Mon Nov 4 13:05:45 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Monitor bridges using vdsStats
......................................................................


Monitor bridges using vdsStats

Changes in vdsm/sampling.py are neccessary because previously no new
interfaces would be added to vdsStats. It would happen only after
restart vdsmd and therefore reinitializaton of HostStatsThread. Now
there is update of ifids and ifrates everytime sample is taken.

To give HostStatsThread time to collect data for statistics we skips
hotplugged interfaces what does not have all samples. In current setting
with AVERAGING_WINDOW==5 and SAMPLE_INTERVAL_SEC==2 it takes 10 seconds
to start giving information about hotplugged interface.

Change-Id: If73565bf62f339e338d65b0200a1ba7f1131b706
Bug-Url: https://bugzilla.redhat.com/675560
Bug-Url: https://bugzilla.redhat.com/988469
Signed-off-by: Petr Sebek <psebek at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/16227
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/clientIF.py
M vdsm/sampling.py
2 files changed, 12 insertions(+), 17 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/16227
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If73565bf62f339e338d65b0200a1ba7f1131b706
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek <psebek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Petr Šebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list