Change in vdsm[master]: Avoid M2Crypto races

danken at redhat.com danken at redhat.com
Mon Nov 4 10:00:13 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Avoid M2Crypto races
......................................................................


Patch Set 1: Verified+1

(1 comment)

Verified that Vdsm still works with this. I have not experienced the race condition, though.

....................................................
Commit Message
Line 7: Avoid M2Crypto races
Line 8: 
Line 9: As documented in
Line 10: http://www.heikkitoivonen.net/m2crypto/api/M2Crypto.threading-module.html
Line 11: and painfully recognized long ago in https://bugzilla.redhat.com/482420,
this bug is sooo ancient that it would not help backporting. We should not touch this piece of archaeology. We'd need a fresh bug, if the annoying downstream maintainer insists to have a bug ;-)
Line 12: using M2Crypto in a multi-threaded server such as Vdsm requires explicit
Line 13: initialization.
Line 14: 
Line 15: Change-Id: I83a3ab41a7001758bd37b0124904fbcd0387ffbf


-- 
To view, visit http://gerrit.ovirt.org/20813
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83a3ab41a7001758bd37b0124904fbcd0387ffbf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list