Change in vdsm[master]: cleanup: Improve lib/vdsm imports (PEP328)

mtayer at redhat.com mtayer at redhat.com
Sun Nov 3 18:31:04 UTC 2013


mooli tayer has posted comments on this change.

Change subject: cleanup: Improve lib/vdsm imports (PEP328)
......................................................................


Patch Set 4:

(1 comment)

....................................................
Commit Message
Line 29:     from . import moduleX
Line 30:     from ..subpackage2 import moduleZ
Line 31: 
Line 32: Which makes it much more evident where things are and avoids possible
Line 33: shadowing of packages in site-packages.
As a newb to python, I find these type of imports nicer to tell top level modules from package modules. If this forces us to have code base locations matching deployment locations that could be nice too.
Line 34: 
Line 35: Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12


-- 
To view, visit http://gerrit.ovirt.org/20555
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list