Change in vdsm[master]: tests: Add miniaml issciadm tests

smizrahi at redhat.com smizrahi at redhat.com
Sun Nov 3 16:32:30 UTC 2013


Saggi Mizrahi has posted comments on this change.

Change subject: tests: Add miniaml issciadm tests
......................................................................


Patch Set 11:

I understand what you are testing I just don't understand why  you want to test that.
It can't catch any mistake, if you change the arguments because of a misstype someone will catch that. It is the kind of errors you don't guard against. If you change the arguments on purpose then you just added a new place to change it as well to make sure he is really sure that the interface changed.

And I understand what the fake module does I just don't think it's something that needs to be done since stubs need to simulate something. They can't be empty or they are useless and can only test useless cases like the cases in this patch.

-- 
To view, visit http://gerrit.ovirt.org/19856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ed21408c7b496c384053ce02cdb66d47df9a14b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list