Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism

amuller at redhat.com amuller at redhat.com
Sun Nov 3 14:05:18 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
......................................................................


Patch Set 10:

(1 comment)

....................................................
File lib/vdsm/tool/upgrade.py
Line 36:             self.log = logging.getLogger('vdsm-tool')
Line 37:         except Exception:
Line 38:             logging.basicConfig(filename='/dev/stdout', filemode='w+',
Line 39:                                 level=logging.DEBUG)
Line 40:             logging.error("Could not init proper logging", exc_info=True)
I don't care much if upgrades are ran as part of vdsm-tool or by some other mechanism. I don't think the comparison to vdsClient is valid. Either case, I'd still want logs of successful / failed upgrades, what did they do and when they were ran. If we just log to /var/log/messages the data might be lost by the time the user reports a bug or asks for help.
Line 41: 
Line 42:     def isNeeded(self):
Line 43:         return not os.path.exists(self.upgradeFilePath)
Line 44: 


-- 
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list