Change in vdsm[master]: fcp: Deactivate vdsm volume groups during boot

Alon Bar-Lev alonbl at redhat.com
Sun Nov 3 09:24:31 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: fcp: Deactivate vdsm volume groups during boot
......................................................................


Patch Set 1:

> you can touch var/run in the spec file to avoid this problem.

of course that everything that is not long living can be done at pre-start...

> Alon, I much prefer to keep this (temporary) hack out of the main vdsm logic.

why is it temporary?

anyway, from what I see /now/ within the pre-tasks... a cleaner design would have used this logic within vdsm->vdsmd at startup... I think that it is better to create that logic and start a move... which much more control over the process.

-- 
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list