Change in vdsm[master]: fcp: Deactivate vdsm volume groups during boot

danken at redhat.com danken at redhat.com
Fri Nov 1 00:03:42 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: fcp: Deactivate vdsm volume groups during boot
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Ayal, the current implementation would not cut the storage under a running VM, as it makes sure deactivate_vdsm_vgs runs only once since boot.

Moving the code to a pre-task would save you the need to duplicate this service for upstart and systemd.

Nir, please add the new file to the Makefile, spec and deb definitions.

....................................................
Commit Message
Line 17: This script must also be used during installation or ugprade. It is safe
Line 18: to invoke it multiple times; it will modify volume groups only on the
Line 19: first run.
Line 20: 
Line 21: On RHEL 6.5 we can use new activation skipping option instead of this
So this is an el6.4.z only patch? Do we need something else for Fedora?

p.s. try to avoid the RHEL trademark, use "el" instead.
Line 22: script. I'll address this in a separate patch.
Line 23: 
Line 24: Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Line 25: Bug-Url: https://bugzilla.redhat.com/1009812


....................................................
File init/sysvinit/vdsm-deactivate-vgs.init
Line 22: ### END INIT INFO
Line 23: 
Line 24: . /etc/init.d/functions
Line 25: 
Line 26: run_file="var/run/vdsm/lvm/deactivate-vgs"
why no leading slash?
Line 27: prog="vdsm-deactivate-vgs"
Line 28: retval=0
Line 29: 
Line 30: log_failure_msg()


Line 38: }
Line 39: 
Line 40: is_first_run()
Line 41: {
Line 42:     test ! -f $run_file
unquoted variables make me weep.
Line 43: }
Line 44: 
Line 45: set_was_run()
Line 46: {


-- 
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f72a68ad09566ba222aa45448c78d1577c40d21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list