Change in vdsm[master]: Split vdsm init script into pieces

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Fri May 31 03:55:58 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: Split vdsm init script into pieces
......................................................................


Patch Set 3: No score

Thanks Alon!

1 and 2: use different wrapper script for Red Hat family and Debian famlily.

I agree with you. As you suggested, the initialization tasks return the error code, and the wrapper prints log messages base on the code. I think messages printed by tasks is helpful and provide more information than error code. Maybe we can just print to stderr in the tasks and have wrapper scripts log "success" and "failure" message based on the error code.

3. the master and the slave script

If I understand correctly, the $FUNCTIONS will be executed in the same order as the slave scripts are sourced, and the order of sourcing the slaves is alphabetic order of the script names.

Yaniv starts to move things into vdsm-tool, I will submit new patch set based on his work and our discussion. Thanks again!

--
To view, visit http://gerrit.ovirt.org/14826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c652704000c764c6e6f248605c6a3f4f3af5ace
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list