Change in vdsm[master]: Supervdsm didn't create pid file when starting up

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Thu May 30 15:59:50 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: Supervdsm didn't create pid file when starting up
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/supervdsmServer.py
Line 360:             sys.exit(errno.EPERM)
Line 361: 
Line 362:         pidfile = P_VDSM_RUN + 'supervdsmd.pid'
Line 363:         pid = str(os.getpid())
Line 364:         file(pidfile, 'w').write(pid + "\n")
Closing it is better and flushes the buffer. If it just writes to the file without closing it, we should flush the buffer explicitly.
Line 365: 
Line 366:         log.debug("Parsing cmd args")
Line 367:         address = sys.argv[1]
Line 368: 


--
To view, visit http://gerrit.ovirt.org/15196
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I649179ca1c614dfcff91da9fada785c57303f57c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list