Change in vdsm[master]: getAllTasksList\Status with spUUID retrieves info only if ho...

bazulay at redhat.com bazulay at redhat.com
Thu May 30 13:04:55 UTC 2013


Barak Azulay has posted comments on this change.

Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM
......................................................................


Patch Set 17: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 2051:         # SPM status changes (HSM tasks or empty task list after cleaning SPM
Line 2052:         # info)
Line 2053:         # To reduce the race we validate SPM status after retreiving
Line 2054:         # empty task list.
Line 2055:         allTasksStatus = self.taskMng.getAllTasksStatuses("spm")
I agree with Fede's comment,

I already think it was discussed in a previous patch set (of this issue). that 2 validations are required, This is the only way we can avoid SPM change issues during this call.
Line 2056:         if spUUID and len(allTasksStatus) == 0:
Line 2057:             self.validateSPM(spUUID)
Line 2058:         return dict(allTasksStatus=allTasksStatus)
Line 2059: 


--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: liron aravot <liron.aravot at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list