Change in vdsm[master]: vdsm: fix RTC offset

danken at redhat.com danken at redhat.com
Tue May 28 18:59:51 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: fix RTC offset
......................................................................


Patch Set 1: (2 inline comments)

....................................................
Commit Message
Line 6: 
Line 7: vdsm: fix RTC offset
Line 8: 
Line 9: Upon RTC update (hwclock --systohc) on the guest side, libvirt sends the event
Line 10: with RTC offset from the qemu start -rtc value in seconds. The received offset
Hacking around this libvirt bug would create more pains in the future. Note that the bug is with us since v3.0. If a vdsm-side hack is urgently needed by a customer, we could send him a hot fix with a strict 

  Conflicts: libvirt > our current version

So the hack can be easily removed later.
Line 11: should not replace the previous value, but should be added to it. Since the
Line 12: time update event is relative to the qemu start time, we should store the
Line 13: initial value and use it for the calculation.
Line 14: 


....................................................
File vdsm/vm.py
Line 350:         self._incomingMigrationFinished = threading.Event()
Line 351:         self.id = self.conf['vmId']
Line 352:         self._volPrepareLock = threading.Lock()
Line 353:         self._initTimePauseCode = None
Line 354:         self._initTimeRTC = None
Why postpone this initialization? Conf is ready right now, I believe.
Line 355:         self.guestAgent = None
Line 356:         self._guestEvent = 'Powering up'
Line 357:         self._guestEventTime = 0
Line 358:         self._vmStats = None


--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list