Change in vdsm[master]: NetReload: netmodels for addNetwork

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue May 28 10:22:52 UTC 2013


Mark Wu has posted comments on this change.

Change subject: NetReload: netmodels for addNetwork
......................................................................


Patch Set 12: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/netmodels.py
Line 298:     def getConfig(self):
Line 299:         try:
Line 300:             ipaddr = self.ip.inet.address
Line 301:             netmask = self.ip.inet.netmask
Line 302:             gateway = self.ip.inet.gateway
should be 
ipaddr = self.inet.address
netmask = self.inet.netmask
gateway = self.inet.gateway
right?
Line 303:         except AttributeError:
Line 304:             ipaddr = netmask = gateway = None
Line 305:         bootproto = self.bootproto


--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list