Change in vdsm[master]: Add a backward reference their master device for Vlan, Bond ...

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue May 28 09:27:28 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Add a backward reference their master device for Vlan, Bond and Nic
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/netmodels.py
Line 112: 
Line 113:     def __init__(self, name, configurator, ipconfig=None, mtu=None, port=None,
Line 114:                  forwardDelay=0, stp=None):
Line 115:         self.validateName(name)
Line 116:         port.master = self
it will throw an exception if port is None. I will fix it in next patch if we still need support nicless bridge.
Line 117:         self.port = port
Line 118:         self.forwardDelay = forwardDelay
Line 119:         self.stp = stp
Line 120:         super(Bridge, self).__init__(name, configurator, ipconfig, mtu)


--
To view, visit http://gerrit.ovirt.org/14870
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba8958549a301c9faac70a32cbafdf320128c85a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list