Change in vdsm[master]: NetReload: netmodels for addNetwork

danken at redhat.com danken at redhat.com
Tue May 28 08:14:40 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: NetReload: netmodels for addNetwork
......................................................................


Patch Set 12: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/netmodels.py
Line 109:     '''This class represents traditional kernel bridges.'''
Line 110:     MAX_BRIDGE_NAME_LEN = 15
Line 111:     ILLEGAL_BRIDGE_CHARS = frozenset(':. \t')
Line 112: 
Line 113:     def __init__(self, name, configurator, ipconfig=None, mtu=None, port=None,
We should continue to support nicless bridges (even though Engine does not have them).
Line 114:                  forwardDelay=0, stp=None):
Line 115:         self.validateName(name)
Line 116:         self.port = port
Line 117:         self.forwardDelay = forwardDelay


--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list