Change in vdsm[master]: Supervdsm as external service

ybronhei at redhat.com ybronhei at redhat.com
Tue May 28 07:03:55 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Supervdsm as external service
......................................................................


Patch Set 13: (2 inline comments)

....................................................
File tests/Makefile.am
Line 55
Line 56
Line 57
Line 58
Line 59
Currently I can't find souitable tests to supervdsm as a service,  I started to do that but the only functionality I came up to check is that supervdsm is responsive to ping request... So it seems redundant for now


....................................................
File vdsm/supervdsm.py
Line 74:         except Exception as ex:
Line 75:             msg = "Connect to supervdsm service failed: %s" % ex
Line 76:             utils.panic(msg)
Line 77: 
Line 78:         self._svdsm = self._manager.instance()
No deeper reason.. I knew that your comment referred to the name of the function. But the connect is called only at startup of vdsm (we omit the relaunch), vdsm starts only after supervdsmd service already up (As it depends on it). It might cause a race when vdsm attempt to connect is faster than supervdsm initialization.. I wasn't sure what is better, but in second thought, we do the same with libvirtconnection so why not here. I'll put it back.
Line 79: 
Line 80:     def __getattr__(self, name):
Line 81:         return ProxyCaller(self, name)
Line 82: 


--
To view, visit http://gerrit.ovirt.org/11051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list